Skip to content

[Workflow Accuracy] Plot DEM with profiles when level > 2 #967

Merged
belletva merged 123 commits into
GlacioHack:mainfrom
marinebcht:961_graph_accuracy
Jun 17, 2026
Merged

[Workflow Accuracy] Plot DEM with profiles when level > 2 #967
belletva merged 123 commits into
GlacioHack:mainfrom
marinebcht:961_graph_accuracy

Conversation

@marinebcht

@marinebcht marinebcht commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Resolves #961

This PR proposes a new kind of graph in the accuracy workflow like this:

diff_elev_after_coreg_map_2

It plots the same dem + colormap as before but with the columns and lines profiles (+ min/max values of each) and replaces if level > 1 the previous :

  • diff_elev_[before/after]_coreg_map.png and the diff_elev_coreg_tba_map.png in case of a coregistration process
  • diff_elev_without_coreg_map.png in case of no coregistration process

Here two examples (level = 2) :

filename="preprocessed_reference_elev_map",
vmin=vmin,
vmax=vmax,
cbar_title=f"Elevation ({self.reference_elev.crs.linear_units})",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

color bar is ALWAYS f"Elevation ({self.reference_elev.crs.linear_units})", so not a param anymore

cmap="RdBu",
)
else:
self.generate_plot_with_profiles(

@marinebcht marinebcht Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one 2x1 plot -> two 1x1 plot

@marinebcht

Copy link
Copy Markdown
Contributor Author

@belletva ready :)

@belletva belletva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me :)

@belletva belletva merged commit 2e29b3d into GlacioHack:main Jun 17, 2026
39 checks passed
marinebcht added a commit to marinebcht/xdem that referenced this pull request Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a new graph in the accuracy workflow

4 participants