chore(deps): bump tar to 0.4.46 and rand to 0.9.3 to clear advisories#105
chore(deps): bump tar to 0.4.46 and rand to 0.9.3 to clear advisories#105beardthelion wants to merge 1 commit into
Conversation
tar 0.4.45 had a PAX header desynchronization issue (GHSA-3pv8-6f4r-ffg2, fixed in 0.4.46); rand 0.9.2 was unsound with a custom logger using rand::rng() (GHSA-cq8v-f236-94qc, fixed in 0.9.3). Both resolve as lockfile-only bumps with no manifest change. Build and cargo audit pass. lru 0.12.5 (GHSA-rhfx-m35p-ff5j) stays pinned by aws-sdk-s3 (lru ^0.12.2) and the hickory advisories remain accepted risk per .cargo/audit.toml (#76).
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jatmn
left a comment
There was a problem hiding this comment.
This PR bumps tar and rand to patched versions that clear two advisories. I found one minor scope/accuracy issue to address before merge.
Findings
- [P3] Document the transitive
windows-syslockfile changes
Cargo.lock
The PR description calls this a "precise lockfile bump" fortarandrand, but the diff also changes selectedwindows-sysversions:dynarraynow resolves towindows-sys 0.48.0(was0.61.2), andgetrandom,rustix, andtempfilenow resolve towindows-sys 0.52.0(was0.61.2). These are normal resolver side-effects of acargo update, but they are not mentioned in the PR body or commit message. Please update the description to list the full lockfile delta so reviewers do not mistake thewindows-sysversion changes for an unintended change.
|
Good catch, updated the description with the full lockfile delta. Walking the diff, the |
jatmn
left a comment
There was a problem hiding this comment.
No actionable findings.
@kevincodex1 LGTM
Two lockfile-only security bumps, no manifest or source changes.
tar0.4.45 -> 0.4.46 clears the PAX header desynchronization issue (GHSA-3pv8-6f4r-ffg2, medium). We use tar incrates/gitlawb-node/src/git/tigris.rsfor archive read/write, which is the affected read path; the fix is behavior-preserving.rand0.9.2 -> 0.9.3 clears therand::rng()custom-logger unsoundness (GHSA-cq8v-f236-94qc, low). Our own code only usesOsRng/RngCore, neverrand::rng(), so this is hygiene for transitive users rather than a path we were exposed on.rand0.8.6 stays, it is outside the vulnerable range.These bumps carry no Cargo.toml version-requirement changes. The
cargo updatedid move four packages onto olderwindows-sysselections already present in the tree, a normal resolver side-effect with no Windows target in our build:colored:windows-sys0.61.2 -> 0.48.0errno:windows-sys0.61.2 -> 0.52.0rustix:windows-sys0.61.2 -> 0.52.0tempfile:windows-sys0.61.2 -> 0.52.0Left alone, with reason:
lru0.12.5 (GHSA-rhfx-m35p-ff5j, low) is pinned by aws-sdk-s3 (lru ^0.12.2) and cannot move to the 0.16.3 fix until aws-sdk-s3 bumps it..cargo/audit.toml, tracked in Drop hickory advisory ignores once libp2p-dns ships hickory 0.26 #76 (waiting on libp2p-dns to ship hickory 0.26).Verification:
cargo build -p gitlawb-node,cargo test -p gitlawb-node(220 passed), andcargo auditall pass; the tar and rand advisories no longer appear.