Fix WISL cell creation bug#367
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WISL is currently set to, when executing
SetCell/SetBound/SetFreed, create the necessary heap entries if the relevant cell is missing. This makes sense when producing assertions, but causes false negatives when these actions are used directly in programs.For example, this program succeeds, where one would expect it to fail as there is no cell at
x:This change adds a
alloc_if_missingargument to various functions, includingWislSMemory.resolve_loc,WislSHeap.set_cell, etc. which specifies whether this behaviour should occur; it is off by default, but enabled insideWislSMemory.produce.