Repository navigation
test: cover Windows classification and refresh saved outputs - #12
Merged
GillMacedo merged 1 commit intoNov 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test compare() computing WindowsOnly for a changed Windows setting alongside a non-Windows setting, rather than setting the flag by hand. Regenerate the shop output and real Cobra output so Windows labels match the current renderer, record the new toolchain, and clarify the platform field comment.
Validation: make test and make lint pass, including vet, all Go tests and both strict offline plugin validations. Removing the WindowsOnly assignment makes the new regression fail. Cobra was checked out at adbc8813901bba65827259daa8e22ff94ec1f30e (Apache-2.0), dependencies downloaded as setup, then scanned with GOPROXY=off and GOTOOLCHAIN=local on Go 1.27.4. The scanner did not build or run Cobra code.
Closes #11
AI assistance: OpenAI Codex implemented, inspected and tested this change. No independent human review is claimed.