Use coal instead of hppfcl#374
Merged
Merged
Conversation
nim65s
reviewed
Jun 5, 2026
nim65s
left a comment
nim65s
left a comment
Member
There was a problem hiding this comment.
should we add coal in package.xml dependecies ?
yes, please
| ) | ||
|
|
||
| if pin.WITH_HPP_FCL and pin.WITH_HPP_FCL_BINDINGS: | ||
| if pin.WITH_COLLISION: |
Member
There was a problem hiding this comment.
This add a pinocchio >= 4 constraint, but I think this is fine
nim65s
approved these changes
Jun 5, 2026
Member
|
@Mergifyio rebase |
|
Member
|
@Mergifyio rebase |
nim65s
force-pushed
the
topic/switch-to-coal
branch
from
e6df7c0 to
4a352f1
Compare
|
Deprecation notice: This pull request comes from a fork and was rebased using |
✅ Branch has been successfully rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is breaking change.
@nim65s Since python package is importing coal directly, should we add coal in package.xml dependecies ?