Add article permalink to notifications#212
Merged
Merged
Conversation
Member
|
This is a good intermediate solution. Happy to merge this, but this does not fully implement the linked issue, which should depend on #102 |
nuest
changed the title
Improves the work landing page with better text wrapping, linking, and map controls for a better user experience. Ensures long titles and metadata wrap properly on smaller screens. Adds clickable links for DOIs and source homepages. Introduces a "Zoom to All Features" button and fullscreen control for the map. Also adds a link to view the raw JSON from the API. Adds tests for the new features on the landing page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of #102 #103
Add article link to notification emails (DOI or URL fallback) by introducing _get_article_link and updating send_monthly_email & send_subscription_based_email
Extend tests to assert both DOI and URL cases.