Update OpenAlex journal sync: dedupe IDs, add error handling#197
Merged
Conversation
nuest
requested changes
Jul 9, 2025
| openalex_id = full_id.rsplit("/", 1)[-1] if isinstance(full_id, str) else None | ||
|
|
||
| # update fields | ||
| safe_upd("openalex_id", openalex_id) |
Member
There was a problem hiding this comment.
Please rewrite into a single update statement, see for example https://stackoverflow.com/questions/41744096/efficient-way-to-update-multiple-fields-of-django-model-object
Member
There was a problem hiding this comment.
I am happy that you check if there actually was a change.
But you can check for changes first, and then if you find a single change, then you update the whole record. You could try doing that via the hash, for example.
Collaborator
Author
There was a problem hiding this comment.
Refactored the loop to collect all changed fields into an updates dict and issue one Source.objects.filter(pk=…).update(**updates) call per record
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve
AttributeError: 'str' object has no attribute 'get':openalex_url(full URI) andopenalex_id(short ID) to avoid redundant dataworks_api_urlpersistence