Added Support for Benders Decomposition#914
Open
dlcole3 wants to merge 28 commits into
Open
Conversation
…ance for multistage
Collaborator
Author
|
@lbonaldo a couple things to note on the tests in this PR:
|
dlcole3
commented
Jun 22, 2026
| run_genx_case_testing(test_path, genx_setup) | ||
| end | ||
|
|
||
| if result_count(EP) == 0 |
Collaborator
Author
There was a problem hiding this comment.
@lbonaldo The test of Julia 1 with Windows errors on this no resources case used for writing outputs. From what I have looked into, it seems like it's a numerical error in HiGHS, likely due to significant NSE at a high penalty. I opted to use a @test_broken line here as I tried many different solver parameters and discussing with Claude and nothing worked in the GitHub workflow test. Open to any thoughts or suggestions you have here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bendersflag was added to the settings (and set as0as the default). Thegenerate_modelfunction was split into a planning level and an operations level. Within the operations level, if theBendersflag in settings is set to1, it will also call acapacity_decisionsfunction which adds copies of the planning level decisions to the subproblems.bendersfunction is used to solve with Benders decomposition.What type of PR is this? (check all applicable)
Related Tickets & Documents
Checklist
How this can be tested
This PR was primarily tested by running against the example cases in the
example_systemsdirectory. I ran examples 1-5, 7, 10, and 11 with and without Benders decomposition (with Gurobi as the solver)Post-approval checklist for GenX core developers
After the PR is approved