Skip to content

Modification to pre-commit requirements#99

Merged
KathleenLabrie merged 1 commit into
mainfrom
fix/modify_pre_commits_reqs
Jun 25, 2026
Merged

Modification to pre-commit requirements#99
KathleenLabrie merged 1 commit into
mainfrom
fix/modify_pre_commits_reqs

Conversation

@KathleenLabrie

Copy link
Copy Markdown
Collaborator

turn off the commit formatting requirement and the automatic fixing for linting and formatting. highlight the issues but do not fix them. that makes diff for relevant code changes hard to follow. keep linting in linting only commits. Also, turn off the ruff magic-trailing-comma formatting for short calls.

…or linting and formatting. highlight the issues but do not fix them. that makes diff for relevant code changes hard to follow. keep linting in linting only commits. Also, turn off the ruff magic-trailing-comma formatting for short calls.
@KathleenLabrie KathleenLabrie self-assigned this Jun 25, 2026

@chris-simpson chris-simpson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, great, looks groovy

@KathleenLabrie

Copy link
Copy Markdown
Collaborator Author

This will be merged despite the failures.

  • source testing and build testing: The failure is a change in the header of the file downloaded from the archive. (The 187 == 181 error). It is fixed in the DRAGONS astrodata and will be incorporated to this astrodata soon, along with the other DRAGONS astrodata commits from the last year+.

  • documentation: This will require troubleshooting. It fails to install scipy because it cannot find OpenBlas. The docs do build fine locally. So updates to the action version and possibly the explicit installation of OpenBlas will likely be needed. That's a future PR.

  • lint: The failures appear to be due to the new rules in this PR. The fixes are in the works in an upcoming PR.

  • integration (source and build): one seems to have tripped because of a temporary failed connection to the conda gemini public channel, and the other to a failure to find a .condarc. The workflow yaml files have comments indicating issues that need to be resolved. Though they passed until the end of July 2025. It could be the change in the node version. We'll look into that in a future PR.

@KathleenLabrie KathleenLabrie merged commit 751772c into main Jun 25, 2026
5 of 15 checks passed
@KathleenLabrie KathleenLabrie deleted the fix/modify_pre_commits_reqs branch June 25, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants