Fix inherited queries using event-query-block

[carstingaxion]

@kofimokome 
The events on the page https://gatherpress.org/event/?cst are sorted in ascending order.
Recent events are on the last page.

in GatherPress slack

Description of the Change

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

• I agree to follow this project's Code of Conduct.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests pass.

[github-actions]

Preview changes with Playground

You can preview the recent changes for PR#1379 with the following PHP versions:

PHP Version 8.4

• Normal WordPress playground for PR#1379
• Seamless WordPress playground for PR#1379
• WordPress playground Builder for PR#1379

PHP Version 8.2

• Normal WordPress playground for PR#1379
• Seamless WordPress playground for PR#1379
• WordPress playground Builder for PR#1379

PHP Version 7.4

• Normal WordPress playground for PR#1379
• Seamless WordPress playground for PR#1379
• WordPress playground Builder for PR#1379

Download .zip with build changes

Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions.

[mauteri]

@carstingaxion can this one be closed? I added a setting that defaults event archive to upcoming, but can also be set to past and none. I believe this PR was debugging this functionality and related. #1587

[carstingaxion]

I guess this was and maybe still is related to a yet unset gatherpress_event_query var.
( I wrote a longer comment on our chats, but can't find)

Let's test it together with #1075

If 1075 is working fine now, this one can be closed.

[mauteri]

It might need to be extended for all event archives (topics, etc) which is fine.

[carstingaxion]

It might need to be extended for all event archives (topics, etc) which is fine.

Maybe even more general: for every query that has a Event supporting type, but not the event-query variation set.

[mauteri]

It might need to be extended for all event archives (topics, etc) which is fine.

Maybe even more general: for every query that has a Event supporting type, but not the event-query variation set.

Need to think about that because the Settings are pretty tied to the Event/Venue post types as they appear in the Events admin menu. With other CPTs I think people will be explicitly setting things probably via filter which is also available right now for this.

[carstingaxion]

Mentally, I'm not at custom post types, but just at how WordPress core generates the request on a (topic) taxonomy archive, if no custom template is registered.

[mauteri]

Mentally, I'm not at custom post types, but just at how WordPress core generates the request on a (topic) taxonomy archive, if no custom template is registered.

I just don't want it to get too confusing is all. I think we can sort this out nicely though.