Skip to content

feat: add walltime benchmark in addition to simulation#175

Merged
beckermr merged 2 commits into
mainfrom
add-walltime-too
Feb 8, 2026
Merged

feat: add walltime benchmark in addition to simulation#175
beckermr merged 2 commits into
mainfrom
add-walltime-too

Conversation

@beckermr

@beckermr beckermr commented Feb 8, 2026

Copy link
Copy Markdown
Collaborator

This PR adds a walltime benchmark in addition to the simulation one. It will be more flaky than the simulation one due to the github hosted runners potentially being different machines on the backend each time. That's ok. It is useful to check things in general.

@beckermr beckermr marked this pull request as ready for review February 8, 2026 14:50
@codspeed-hq

codspeed-hq Bot commented Feb 8, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 34.48%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
✅ 15 untouched benchmarks
🆕 16 new benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation test_benchmarks_lanczos_interp[xval-no_conserve_dc-run] 1,102.6 µs 819.9 µs +34.48%
🆕 WallTime test_benchmark_spergel_xvalue[run] N/A 1.7 s N/A
🆕 WallTime test_benchmarks_lanczos_interp[kval-no_conserve_dc-run] N/A 46.3 µs N/A
🆕 WallTime test_benchmark_interpimage_flux_frac[run] N/A 432.8 µs N/A
🆕 WallTime test_benchmarks_lanczos_interp[xval-no_conserve_dc-run] N/A 88.2 µs N/A
🆕 WallTime test_benchmark_spergel_calcfluxrad[run] N/A 193.3 µs N/A
🆕 WallTime test_benchmark_rng_discard[run] N/A 111.3 µs N/A
🆕 WallTime test_benchmark_gaussian_init[run] N/A 6.3 µs N/A
🆕 WallTime test_benchmark_moffat_init[run] N/A 134.4 µs N/A
🆕 WallTime test_benchmarks_lanczos_interp[kval-conserve_dc-run] N/A 44.1 µs N/A
🆕 WallTime test_benchmarks_lanczos_interp[xval-conserve_dc-run] N/A 120 µs N/A
🆕 WallTime test_benchmark_spergel_init[run] N/A 6.3 µs N/A
🆕 WallTime test_benchmark_spergel_conv[run] N/A 279 ms N/A
🆕 WallTime test_benchmark_spergel_kvalue[run] N/A 11.5 ms N/A
🆕 WallTime test_benchmarks_interpolated_image[run] N/A 5.2 ms N/A
🆕 WallTime test_benchmark_invert_ab_noraise[run] N/A 128.4 µs N/A
🆕 WallTime test_benchmarks_metacal[run] N/A 18.6 ms N/A

Comparing add-walltime-too (64effd9) with main (e9441e3)

Open in CodSpeed

@beckermr beckermr enabled auto-merge (squash) February 8, 2026 15:03
@beckermr beckermr merged commit 2f9500f into main Feb 8, 2026
8 checks passed
@beckermr beckermr deleted the add-walltime-too branch February 8, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant