regression(GOCART2G): use esma_add_regression_tests() macro#464
Closed
pchakraborty wants to merge 2 commits into
Closed
regression(GOCART2G): use esma_add_regression_tests() macro#464pchakraborty wants to merge 2 commits into
pchakraborty wants to merge 2 commits into
Conversation
Replace hand-rolled CMake boilerplate in CMakeLists.txt with a call to esma_add_regression_tests() from ESMA_cmake. Remove the per-component sync_data.cmake (superseded by esma_sync_aws_s3_data.cmake) and extract shared helper functions (copy_directory, link_directory, run_geos, compare_results) into esma_regression_run_helpers.cmake.
|
This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Please add one so that the PR can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hand-rolled CMake boilerplate in
GOCART2G_GridComp/regression/CMakeLists.txtwith a call toesma_add_regression_tests()from ESMA_cmake#553.Changes
CMakeLists.txt— replaced ~60 lines of duplicated boilerplate with a 5-lineesma_add_regression_tests()callrun_case.cmake— removedcopy_directory,link_directory,run_geos, andcompare_resultsfunctions (now provided byesma_regression_run_helpers.cmake);copy_restartsandrun_caseremain as GOCART2G-specific logicsync_data.cmake— deleted; superseded byesma_sync_aws_s3_data.cmakein ESMA_cmakeDependency
Requires ESMA_cmake #553 to be merged first.