refactor(product-domains): move function agent response policy#817
Merged
limityan merged 1 commit intoMay 21, 2026
Merged
Conversation
Move function-agent prompt templates and AI response extraction/error mapping into product-domains while keeping Git/AI service calls in core. Update boundary guards and docs for the H2 closure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitfun-product-domainswhile preserving the existing prompt text byte-for-byte.bitfun-product-domains::function_agents.bitfun-core.product-domains/AGENTS.md, and the boundary check script so H2 no longer describes prompt/response policy as core-owned while still keeping MiniApp IO/worker/host/builtin runtime and Git/AI runtime explicitly core-owned.Behavior Boundary
This PR is intended as a structural owner migration only. It does not move MiniApp filesystem IO, worker process execution, host dispatch, built-in asset seeding or marker IO, Git service execution, AI client calls, tool runtime, or product-surface behavior.
Verification
node scripts/check-core-boundaries.mjsgit diff --check gcwing/main..HEADcargo test -p bitfun-product-domains --features function-agents function_agents:: --libcargo test -p bitfun-core parse_commit_response_preserves_product_domain_response_policy --libcargo test -p bitfun-core parse_complete_analysis_preserves_product_domain_response_policy --libcargo check --workspacecargo test --workspace