refactor(tools): complete H1 provider boundary#815
Merged
limityan merged 1 commit intoMay 21, 2026
Merged
Conversation
Move product tool provider group planning into bitfun-tool-packs while keeping concrete tool materialization, ToolUseContext, GetToolSpec execution, and runtime service handles core-owned. Update boundary guards and docs, and fix remote-connect subagent link routing exposed by full workspace verification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitfun-tool-packswhile keeping concrete tool materialization inbitfun-core.GetToolSpecresult adaptation through the provider-backed runtime facade and keepToolUseContext, unlock state, concrete tools, and product registry snapshots core-owned.SubagentSessionLinkedrouting in CLI and remote-connect trackers after the latest event-shape changes.Adversarial Review Notes
gcwing/main; it does not move concrete tools,ToolUseContext, workspace services, snapshot wrappers, or product runtime handles out of core.tool-packsand core registry tests; GetToolSpec and remote-connect regressions are covered by focused tests.AGENTS.md, module AGENTS files, and decomposition docs now state thattool-packsowns provider planning only, not concrete runtime behavior.Validation
node scripts/check-core-boundaries.mjsgit diff --check gcwing/main..HEADcargo check --workspacecargo test -p bitfun-services-integrations --features remote-connect --test remote_connect_contractscargo test -p bitfun-agent-tools --test tool_contractscargo test -p bitfun-tool-packs --libcargo test -p bitfun-core builtin_static_tool_providers_follow_tool_pack_group_plan --libcargo test -p bitfun-core get_tool_spec --libcargo test --workspace