refactor(tools): move generic runtime assembly contracts#810
Merged
limityan merged 1 commit intoMay 20, 2026
Merged
Conversation
Delegate static-provider assembly, decorator references, snapshot decorator adapter, and readonly filtering to bitfun-agent-tools. Keep product provider groups, snapshot wrapper integration, ToolUseContext, and GetToolSpec execution owned by core.
2e5938e to
d765957
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitfun-agent-tools.ToolUseContext, runtime manifest facade, andGetToolSpecexecution inbitfun-core.ToolUseContext, runtime manifest /GetToolSpecowner work, or a single concrete tool feature group.Safety / Behavior
wrap_tool_for_snapshot_trackingpath through the core-owned product wrapper adapter.GetToolSpecunlock behavior are covered by focused tests.Validation
git rebase gcwing/maincargo test -p bitfun-agent-tools --test tool_contractscargo test -p bitfun-core product_tool_runtime_assembly --libcargo test -p bitfun-core registry_ --libcargo test -p bitfun-core manifest_ --libcargo test -p bitfun-core get_tool_spec --libcargo test -p bitfun-core dynamic_tool_provider_ --libcargo check -p bitfun-core --features product-fullcargo check -p bitfun-agent-toolscargo check -p bitfun-corenode scripts/check-core-boundaries.mjsrustfmt --edition 2021 --check src/crates/agent-tools/src/framework.rs src/crates/agent-tools/src/lib.rs src/crates/agent-tools/tests/tool_contracts.rs src/crates/core/src/agentic/tools/runtime_assembly.rsgit diff --check gcwing/main..HEAD