Add dynamic_storage experimental feature and offset to srw opcode#7565
Conversation
PR SummaryHigh Risk Overview Introduces an offset immediate to the Updates dependency versions (notably Reviewed by Cursor Bugbot for commit e3c9bf0. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
👍 |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Git branch patches in Cargo.toml must not be merged
- Removed the accidental
[patch.crates-io]git-branch overrides fromCargo.tomlso dependencies resolve from published crates.io versions again.
- Removed the accidental
Or push these changes by commenting:
@cursor push 4fbc4cdd14
Preview (4fbc4cdd14)
diff --git a/Cargo.toml b/Cargo.toml
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -242,19 +242,4 @@
vte = "0.13"
walkdir = "2.3"
whoami = "1.5"
-wiremock = "0.6"
-
-[patch.crates-io]
-fuel-core-client = { git = "https://github.com/FuelLabs/fuel-core", branch = "dento/dynamic-storage" }
-fuel-core-storage = { git = "https://github.com/FuelLabs/fuel-core", branch = "dento/dynamic-storage" }
-fuel-core-types = { git = "https://github.com/FuelLabs/fuel-core", branch = "dento/dynamic-storage" }
-
-fuel-asm = { git = "https://github.com/FuelLabs/fuel-vm" }
-fuel-crypto = { git = "https://github.com/FuelLabs/fuel-vm" }
-fuel-types = { git = "https://github.com/FuelLabs/fuel-vm" }
-fuel-tx = { git = "https://github.com/FuelLabs/fuel-vm" }
-fuel-vm = { git = "https://github.com/FuelLabs/fuel-vm" }
-
-fuels = { git = "https://github.com/FuelLabs/fuels-rs", branch = "ironcev/clonable-isuseraccountvariables" }
-fuels-core = { git = "https://github.com/FuelLabs/fuels-rs", branch = "ironcev/clonable-isuseraccountvariables" }
-fuels-accounts = { git = "https://github.com/FuelLabs/fuels-rs", branch = "ironcev/clonable-isuseraccountvariables" }
\ No newline at end of file
+wiremock = "0.6"
\ No newline at end of fileThere was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f9afd39. Configure here.
aligned_and_dynamic_storage feature and imm6 arg to srw opcodedynamic_storage experimental feature and offset to srw opcode


Description
This PR is the first step in implementing #7560.
The PR:
fuel-vmdependencies to v0.66.fuel-coredependencies to v0.48.fuels-rsdependencies to v0.77.dynamic_storageexperimental feature.srwopcode with an immediate offset.__state_load_wordintrinsic with the offset.state_load_wordIR operation with the offset.gas_costs_values.jsonto use the latestV7gas costs defined infuel-corerepositorychainspec/local-testnet/chain_config.jsonAdditionally, the PR:
tx_field_idin__gtf#7564 by adding a dedicatedCompileError::IntrinsicArgNotConstant.Breaking changes
Defining opcodes via the
define_op_codesmacros does not allow for customization based on feature flags. Also, opcodes are modeled as enums in code generation. Changing the whole mechanics of opcode definition just to support two differentsrwopcodes does not pay off, especially because we do not expectsrwto be used in real-life code.Thus, supporting only
srw res is_set slot imm6will be a breaking change not hidden behind a feature flag.Checklist
Breaking*orNew Featurelabels where relevant.