Frontend Refactor

[DavideIadeluca]

Fixes #0000

Changes proposed in this pull request:

• Target 1.x workflows
• Use frontend extenders
• TS Refactor

Reviewers should focus on:

• I tried to properly use TS as far as reasonably possible. At some point I had to stop because logic would have to be rewritten and I'm afraid that I might introduce regression.

Screenshot

Confirmed

• Frontend changes: tested on a local Flarum installation.
• Backend changes: tests are green (run composer test).

Required changes:

• Related Flarum core extension PR's: (Omit this section if irrelevant)

[DavideIadeluca]

@dsevillamartin I would be glad if you could also take a glance at this, particularly the changes in the UserBio component itself

[dsevillamartin]

Overall looks good, haven't tested locally though.

[dsevillamartin]

I'd type this in the function itself - I believe this should work. (Does UserCard not have the attributes typed?)

Suggested change

	extend(UserCard.prototype, 'infoItems', function (items: ItemList<Mithril.Children>) {
	extend(UserCard.prototype, 'infoItems', function (items: ItemList<Mithril.Children>, this: any) {

[dsevillamartin]

I'm not sure if having values moved from oninit to instance creation causes any issues or not... theoretically oninit should only be called once, and since these are primitives it shouldn't really matter as there are no side effects? Just some thoughts.

[dsevillamartin]

Why are all these ts-ignores necessary?

[imorland]

Please note a minor change I made today in the released version:

user-bio/js/src/forum/components/UserBio.js

Line 117 in f30b872

'<p>' + $('<div/>').text(user.bio()).html().replace(/\n/g, '<br>').autoLink({ rel: 'nofollow ugc', target: '_blank' }) + '</p>'

(added ugc and target="_blank" by default)