Skip to content

[1.x] fix: prevent google/recaptcha from updating to v1.5 or later#54

Merged
dsevillamartin merged 1 commit into
1.xfrom
ds/1.x-fix-google-recaptcha-fatal
May 30, 2026
Merged

[1.x] fix: prevent google/recaptcha from updating to v1.5 or later#54
dsevillamartin merged 1 commit into
1.xfrom
ds/1.x-fix-google-recaptcha-fatal

Conversation

@dsevillamartin

Copy link
Copy Markdown
Member

v1.3 is the latest for PHP 8.3, but PHP 8.4 supports the latter, and v1.5 has breaking changes that give a Fatal notice error.

Changes proposed in this pull request:
google/recaptcha v1.5 introduces breaking changes. Hard to catch since v1.4 and later require PHP 8.4+.

Fatal error: Declaration of FoF\ReCaptcha\ReCaptcha\GuzzleRequestMethod::submit(ReCaptcha\RequestParameters $params) must be compatible with ReCaptcha\RequestMethod::submit(ReCaptcha\RequestParameters $params): string in <FLARUM>\fof-recaptcha\src\ReCaptcha\GuzzleRequestMethod.php on line 36

Reviewers should focus on:

Screenshot

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

v1.3 is the latest for PHP 8.3, but PHP 8.4 supports the latter, and v1.5 has breaking changes that give a **Fatal notice** error.
@dsevillamartin dsevillamartin requested a review from a team as a code owner May 30, 2026 15:48
@dsevillamartin dsevillamartin changed the base branch from 2.x to 1.x May 30, 2026 15:50
@dsevillamartin dsevillamartin merged commit 3f6dd70 into 1.x May 30, 2026
8 of 18 checks passed
@dsevillamartin dsevillamartin deleted the ds/1.x-fix-google-recaptcha-fatal branch May 30, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant