[2.x] Modernise PHPUnit configuration#153
Merged
Merged
Conversation
Update the unit and integration PHPUnit config to the current schema (matching other FoF extensions): reference the local phpunit.xsd, add a cacheDirectory, use backupStaticProperties, replace the deprecated <coverage> element with <source>, and drop the removed convert*ToExceptions attributes and the Mockery TestListener. Ignore the new .phpunit.cache directory. Removes the PHPUnit deprecation notices emitted on every test run.
imorland
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The unit and integration PHPUnit configs still used the PHPUnit 9.3 schema and attributes that have since been removed, so every test run emitted deprecation notices ("OK, but there were issues!").
This updates both configs to the current format, matching other FoF extensions (e.g.
fof/seo):../vendor/phpunit/phpunit/phpunit.xsdinstead of the pinnedschema.phpunit.de/9.3URLcacheDirectory=".phpunit.cache"(and gitignore it)backupStaticPropertiesinstead of the renamedbackupStaticAttributes<coverage>element with<source>convertErrorsToExceptions/convertNoticesToExceptions/convertWarningsToExceptionsattributes and the obsolete MockeryTestListenerNo test behaviour changes — the suite runs clean with no deprecations.