Fix "replace http cache" not working in dev#9136
Open
PikachuEXE wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
the
PR: waiting for review
absidue
reviewed
May 14, 2026
Member
absidue
left a comment
absidue
left a comment
There was a problem hiding this comment.
From the docs:
This method can only be used before the ready event of the app module gets emitted and can be called only once.
https://www.electronjs.org/docs/latest/api/protocol#protocolregisterschemesasprivilegedcustomschemes
I would suggest moving it to the else block on the if prod, that way for release builds it will be called once with both schemes and in dev once with one scheme
Member
Electron 42, I only fixed the release builds in the electron pr, i should have fixed dev at the same time, sorry. |
… can be called once only
Member
Author
|
OK fixed |
absidue
approved these changes
May 14, 2026
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater and
efb4f5ff-1298-471a-8973-3d47447115dc
ChunkyProgrammer
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
N/A
Description
Dunno why CORS started to be not working today when testing #9134 (audio format)
Found this in console
Screenshots
Testing
Desktop
Additional context
Dunno if new electron version or whatever causing this