Repository navigation
Fix property serialization bounds checks - #382
Merged
Merged
Conversation
allanli4
force-pushed
the
fix/property-buffer-size-check
branch
from
August 5, 2026 22:27
0726a29 to
474324f
Compare
allanli4
changed the title
allanli4
changed the title
AniruddhaKanhere
approved these changes
Aug 5, 2026
allanli4
force-pushed
the
fix/property-buffer-size-check
branch
from
August 6, 2026 20:51
474324f to
736d841
Compare
rawalexe
approved these changes
Aug 6, 2026
The size check reserved propertyLength + 2 bytes, but a serialized UTF-8 property occupies propertyLength + 3: one byte for the property ID, two for the length prefix, and propertyLength for the string. A buffer advertised as propertyLength + 2 was therefore accepted and written one byte past its end. Reserve propertyLength + 3, and add a unit test and a CBMC proof for MQTTPropAdd_ReasonString covering the boundary.
allanli4
force-pushed
the
fix/property-buffer-size-check
branch
from
August 13, 2026 20:42
736d841 to
519c77f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix property serialization bounds checks
Thank you XueDugu for reporting the issue.
Test Steps
test_MQTTPropAdd_ReasonString_BufferTooSmalltocore_mqtt_prop_serializer_utest.c.test/cbmc/proofs/MQTTPropAdd_ReasonString/covering the write path ofaddPropUtf8viaMQTTPropAdd_ReasonString.Checklist:
Related Issue
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.