TFTP / Networking fixes#35
Merged
InvoxiPlayGames merged 7 commits intoJun 9, 2026
Merged
Conversation
- If networking is disabled, also disable TFTP - in kbootconf.c, don't bother trying TFTP boot when TFTP is disabled - in kbootconf.c, don't try to reinitialize the network if networking is disabled - in main.c, don't try to poll the network if TFTP is disabled
- update netif.dhcp code to use the new function for getting DHCP data - include lwip/init.h for LWIP_VERSION_MAJOR and create macros to handle API differences so we compile without warnings on both versions - use `ip_addr_t` (which is `typedef struct ip_addr` already!) instead of `struct ip_addr`
mitchellwaite
changed the title
InvoxiPlayGames
approved these changes
Feb 21, 2026
Member
|
This would be ready to be merged if the merge conflict can be resolved |
… into dontCrashWhenNetworkingIsDisabled
Contributor
Author
|
@InvoxiPlayGames merge conflict is now resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to make a version of XeLL that could live on a DVD and boot a linux installer, I noticed a few issues with the TFTP and networking flags that were causing issues and crashes when those features were disabled. To resolve those issues, this PR makes the following changes:
unused variablecompiler warningsfallback_addresswas changed totftp_fallback_addressand placed inside the TFTP ifndef block to make it more clear what the variable is used forIn addition, this change also adds macros to the beginning of, and make changes to, tftp.c such that it will compile against both the current lwip 1.4.1 and the 2.2.1 branch i'm working on