Repository navigation
Fix: 2 issues (#1058, #1063) - #1124
Open
whiteghost0001 wants to merge 1 commit into
Open
whiteghost0001 wants to merge 1 commit into
whiteghost0001 wants to merge 1 commit into
Conversation
Co-authored-by: Simple Agent <agent@simple.dev>
|
@whiteghost0001 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1058
Closes #1063
Issues
#1058 frontend: [Dashboard] DASHBOARD [DB-005]: Build admin system configuration page
#1063 frontend: [Dashboard] DASHBOARD [DB-010]: Build historical yield transactions audit list
Summary
Both pages already contain substantial scaffolding; focus on completing the on-chain submission path for the fee form and the full sortable/searchable table UI for the audit list. Keep the superadmin gate on fee changes. For the on-chain fee update, prefer a backend builder endpoint that returns an unsigned XDR, then sign with Freighter and submit; if no builder exists, construct the invoke_contract_function XDR client-side. For the audit table, reuse the existing YieldTx type and api.yieldAuditLogs, and make sure pagination uses the API total rather than only the loaded page.
Changes