Leverage rule indexing for CollapseNullStrictValueOverNullValueRule#4260
Open
RobertBrunel wants to merge 1 commit into
Open
Leverage rule indexing for CollapseNullStrictValueOverNullValueRule#4260RobertBrunel wants to merge 1 commit into
CollapseNullStrictValueOverNullValueRule#4260RobertBrunel wants to merge 1 commit into
Conversation
Remove `CollapseNullStrictValueOverNullValueRule` from the always-rules bucket of `DefaultValueSimplificationRuleSet` and instead create multiple instances of the rule, one instance per strictly null-propagating subclass `Value` subclass (such as `CastValue`, et cetera). To this end, introduce a `V` type parameter and build a `typedMatcherWithPredicate` directly for `V.class`. This reduces the overhead in trying to match this rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
CollapseNullStrictValueOverNullValueRulefrom the always-rules bucket ofDefaultValueSimplificationRuleSetand instead create multiple instances of the rule, one instance per strictly null-propagating subclassValuesubclass (such asCastValue, et cetera). To this end, introduce aVtype parameter and build atypedMatcherWithPredicatedirectly forV.class.This reduces the overhead in trying to match this rule.