Generalize indexing of planner rules to support multiple concrete classes per rule#4254
Draft
RobertBrunel wants to merge 2 commits into
Draft
Generalize indexing of planner rules to support multiple concrete classes per rule#4254RobertBrunel wants to merge 2 commits into
RobertBrunel wants to merge 2 commits into
Conversation
…sses per rule * Generalize `PlannerRule.getRootOperator()` to `getRootOperators()`, which returns a set of classes. * Also add a `BindingMatcher.getRootClasses()` counterpart, which defaults to `Set.of(getRootClass()))`. * In `AbstractRuleSet`, have each rule indexed under each class it advertises via `getRootOperators()`. * Add a `MultiTypedMatcher` and a corresponding `ValueMatchers.anyValueOfType(…)` wrapper that utilize the multi-class indexing to efficiently bind a union of concrete subclasses. * Leverage `anyValueOfType()` in `CollapseNullStrictValueOverNullValueRule` to remove it from the always-rules bucket and efficiently match exactly the six strict-null-propagating `Value` subclasses that matter.
RobertBrunel
force-pushed
the
TypedMatcher
branch
from
7a5a1fc to
57f50f3
Compare
RobertBrunel
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental.