Hide 'Move to' action for media in recycle bin#1068
Open
Phoenix1808 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #692.
Hides the "Move to" action in the fullscreen viewer (ViewPagerActivity)
when the media is in the recycle bin, where moving isn't supported and
currently just shows an error. This matches the existing behavior in the
grid selection (MediaAdapter) and the sibling menu items here
(menu_rename, menu_hide, menu_add_to_favorites).
Note: I wasn't able to run the app locally yet (Android SDK not set up),
but the change mirrors the established pattern in the same function.
Happy to add screenshots if needed.