Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes UI Style Kit CSS by improving packaging/docs and tightening the theme implementation so consumers get predictable overrides (via cascade layers) plus broader native HTML + accessibility coverage, alongside new “check” scripts and Playwright visual snapshot scaffolding.
Changes:
- Wrapped each UI system stylesheet in an explicit
@layer ui-style-kit.*and updated multiple token values for better contrast. - Added/expanded “native HTML coverage + accessibility helpers” blocks in select UI systems and introduced visual snapshot tests against the demo.
- Refreshed documentation and contributor/publishing guidance to match the new build/check workflow and package export structure.
Reviewed changes
Copilot reviewed 29 out of 32 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updated usage/docs for new bundle layout, cascade layers, and checks; includes CDN guidance. |
| CONTRIBUTING.md | Rewritten contribution workflow around npm run check and public API stability. |
| CHANGELOG.md | Condensed release notes describing layering, contrast fixes, scripts, and exports. |
| SECURITY.md | Clarified CSS-only scope and what is considered in/out of security scope. |
| STYLE-MAP.md | Updated mapping of UI systems/themes/modes to current package structure. |
| package.json | Updated exports map, scripts (build/check/release), and package metadata. |
| scripts/build.mjs | Builds dist/ui-style-kit.css + minified bundle and declares @layer order banner. |
| scripts/check-contrast.mjs | Adds automated contrast checks across UI/theme/mode combinations. |
| scripts/check-package.mjs | Adds package integrity checks (required files/exports, no runtime deps). |
| demo/index.html | New/updated demo used as the baseline for visual checks. |
| index.html | Updated root demo entry to reference the new build output. |
| playwright.config.mjs | Adds Playwright config intended for snapshot runs. |
| tests/demo-visual.spec.mjs | Adds visual snapshot smoke coverage across UI systems and modes. |
| docs/TOKENS.md | Documents stable token families and override patterns. |
| docs/STYLE-GUIDE.md | Describes how to choose a UI style; includes visual regression guidance. |
| docs/PUBLISHING.md | Documents dry-run and publishing/release commands. |
| styles/y2k.css | Adds @layer wrapping, contrast token tweaks, and native HTML/accessibility coverage. |
| styles/retro-glass.css | Adds @layer wrapping, contrast token tweaks, and native HTML/accessibility coverage. |
| styles/tactile.css | Adds @layer wrapping and token tweaks; closes the layer block. |
| styles/retrofuturism.css | Adds @layer wrapping and token tweaks; closes the layer block. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Foscat
added a commit
that referenced
this pull request
Jun 5, 2026
* [feat] Better UI theme implimentations and dep cleaning * chore: sync package.json version with main * fix review-thread issues from PR #29 * chore: sync package.json version with main --------- Co-authored-by: Foscat <fosterkyle6356@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Foscat
added a commit
that referenced
this pull request
Jun 6, 2026
* [feat] Better UI theme implimentations and dep cleaning * chore: sync package.json version with main * fix review-thread issues from PR #29 * chore: sync package.json version with main --------- Co-authored-by: Foscat <fosterkyle6356@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces significant improvements to the documentation and user guidance for UI Style Kit CSS. The changes clarify the package's features, usage, and contribution process, and add details on accessibility, cascade layering, and security scope. The documentation is now more concise, up-to-date, and focused on the current package structure and consumer experience.
Documentation and Guidance Improvements:
README.md: Updated to clarify features, usage instructions, CDN integration, dynamic switching, and the role of cascade layers; added details on accessibility coverage and restructured the file to match the new package layout. The integration bridge with Interactive Surface CSS is now referenced as included in the combined build, and shortcut import paths are documented. [1] [2] [3] [4] [5]CONTRIBUTING.md: Rewritten to provide a clear, step-by-step local workflow, contribution guidelines, and versioning policy. Emphasizes CSS-only nature, stability requirements, and documentation updates for public API changes.CHANGELOG.md: Reformatted to focus on UI Style Kit CSS, summarizing major changes, new features, and build/package updates for version 0.2.0.SECURITY.md: Simplified to clarify the package's CSS-only scope, what is in and out of security scope, and how to report concerns.STYLE-MAP.md: Removed outdated references to the companion bridge, reflecting the updated integration approach.These updates make the library easier to use, contribute to, and integrate, while ensuring the documentation accurately reflects the current state and philosophy of the project.
Type of Change
Validation
npm run lint:cssindex.htmldemoChecklist