Conversation
- Changed release trigger from 'created' to 'published' in npm publish workflow. - Added validation step to ensure release tag aligns with package version. - Updated package and changelog metadata to reflect version 1.1.1. - Aligned package-lock.json with package.json version.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ag/branch ambiguity
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request aims to improve release/version automation reliability by making the sync workflow’s push target unambiguous (branch refs), and documenting the change in the changelog.
Changes:
- Updated the sync workflow
git pushrefspec to explicitly push torefs/heads/...to avoid branch/tag ref ambiguity. - Added an
[Unreleased]changelog entry describing the sync workflow fix. - Updated
package-lock.jsonroot metadata version fields.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
package-lock.json |
Adjusts lockfile version metadata values (currently to 1.0.4). |
CHANGELOG.md |
Adds an [Unreleased] “Fixed” entry describing the workflow push change. |
.github/workflows/sync-package-version-with-main.yml |
Disambiguates push destination by targeting refs/heads/<branch>. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+8
to
+10
| ### Fixed - Sync workflow push ambiguity | ||
|
|
||
| - Fixed `git push` in `.github/workflows/sync-package-version-with-main.yml` to explicitly target branch refs, preventing potential conflicts with tag refs. |
Comment on lines
+8
to
+10
| ### Fixed - Sync workflow push ambiguity | ||
|
|
||
| - Fixed `git push` in `.github/workflows/sync-package-version-with-main.yml` to explicitly target branch refs, preventing potential conflicts with tag refs. |
| git add package.json | ||
| git commit -m "chore: sync package.json version with main" | ||
| git push origin "HEAD:${GITHUB_HEAD_REF:-${GITHUB_REF_NAME}}" | ||
| git push origin "HEAD:refs/heads/${GITHUB_HEAD_REF:-${GITHUB_REF_NAME}}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses a minor but important fix to the sync workflow for package versioning. The main change ensures that the workflow's
git pushcommand explicitly targets branch references, preventing ambiguity and potential conflicts with tag refs. This update is also documented in theCHANGELOG.md.Sync workflow reliability improvements:
git pushcommand in.github/workflows/sync-package-version-with-main.ymlto specifyrefs/heads/for the branch, ensuring pushes go to the correct branch and not tags.Documentation:
Type of Change
Validation
npm run lint:cssindex.htmldemoChecklist