Skip to content

Initial PR for Titanic Model#338

Open
arcAman07 wants to merge 2 commits into
FluxML:masterfrom
arcAman07:master
Open

Initial PR for Titanic Model#338
arcAman07 wants to merge 2 commits into
FluxML:masterfrom
arcAman07:master

Conversation

@arcAman07

@arcAman07 arcAman07 commented Feb 21, 2022

Copy link
Copy Markdown

Initially as I was told, this PR contains the function which fetches the data from the MLDatasets Library, divides them into training and testing set so that it can be used to create the ML model using Flux.jl

Things to be added: Updated ReadMe, Toml file consisting of the dependency and updating docs.
If this is right, will add rest of the things along with Flux implementation of the Titanic dataset

@arcAman07 arcAman07 changed the title Initial PR just for Titanic Model Initial PR for Titanic Model Feb 21, 2022
@darsnack

Copy link
Copy Markdown
Member

While there is nothing wrong with what's already in the PR, this will need all the "things to add" like a README, toml, complete training script, etc. before it is ready for review.

You do not need to close this PR, just keep pushing more commits.

@arcAman07

arcAman07 commented Feb 21, 2022

Copy link
Copy Markdown
Author

Cool will keep adding the commits, was told the initial PR will be for just processing the data which will be ready to use by the Flux library. Thought of adding rest of the things after this was approved.
Will add README,toml and the training scipt too.

@mcabbott mcabbott added the new model new arrival in the zoo label Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new model new arrival in the zoo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants