Initial PR for Titanic Model#338
Open
arcAman07 wants to merge 2 commits into
Open
Conversation
Member
|
While there is nothing wrong with what's already in the PR, this will need all the "things to add" like a README, toml, complete training script, etc. before it is ready for review. You do not need to close this PR, just keep pushing more commits. |
Author
|
Cool will keep adding the commits, was told the initial PR will be for just processing the data which will be ready to use by the Flux library. Thought of adding rest of the things after this was approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially as I was told, this PR contains the function which fetches the data from the MLDatasets Library, divides them into training and testing set so that it can be used to create the ML model using Flux.jl
Things to be added: Updated ReadMe, Toml file consisting of the dependency and updating docs.
If this is right, will add rest of the things along with Flux implementation of the Titanic dataset