Conversation
## Summary - Add a new `BrightroomParametric` SwiftPM product/target for platform-neutral parametric editing features. - Move Feature documents, registry-backed definitions, graph compilation, image rendering, video rendering, and Metal-backed mask kernels into the new module. - Keep the `EditingStack` bridge inside `BrightroomEngine` so legacy `EditingStack.Edit.Filters` can convert into parametric feature pipelines without making the new module depend on Engine/UI. - Add SwiftUI image/video playgrounds plus a lightweight macOS `ParametricMacDemo` target for interactive checks. ## Notes `Package.swift` now declares macOS support so the new `BrightroomParametric` product can build for macOS. This PR does not make the UIKit-backed `BrightroomEngine` or `BrightroomUI` surfaces a full macOS port. ## Validation - `plutil -lint Dev/Brightroom.xcodeproj/project.pbxproj` - `xcodebuild -project Dev/Brightroom.xcodeproj -scheme ParametricMacDemo -destination 'platform=macOS' -derivedDataPath build/CodexDerivedData build` - `xcodebuild -project Dev/Brightroom.xcodeproj -scheme BrightroomEngineTests -destination 'platform=iOS Simulator,id=05718949-3329-4852-9F7A-FA1649441821' -destination-timeout 60 -derivedDataPath build/CodexDerivedData -only-testing:BrightroomEngineTests/ParametricFeatureTreeTests test` - `xcodebuild -project Dev/Brightroom.xcodeproj -scheme SwiftUIDemo -destination 'platform=iOS Simulator,id=05718949-3329-4852-9F7A-FA1649441821' -destination-timeout 60 -derivedDataPath build/CodexDerivedData build`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.