Codex/photoscrop perspective projection#286
Draft
muukii wants to merge 38 commits into
Draft
Conversation
- Resolve conflicts in Package.swift, Package.resolved - Update Demo files to use StateGraph instead of Verge - Replace $editingStackState.driver with editingStack Co-Authored-By: Claude (global.anthropic.claude-opus-4-5-20251101-v1:0) <noreply@anthropic.com>
## Summary - Add `.cube` LUT parsing alongside the existing image-based LUT flow. - Let `FilterColorCube` use either an image LUT or raw `CIColorCubeWithColorSpace` cube data. - Load bundle `*.cube` files through `ColorCubeLoader`, using `LUT_3D_SIZE` and optional `TITLE` metadata from the file. - Add parser, loader, and filter-output coverage for `.cube` LUTs. ## Notes - `.cube` files with the default `0...1` domain are supported. - Non-default `DOMAIN_MIN` / `DOMAIN_MAX` currently throw an explicit unsupported-domain error rather than silently applying a wrong transform. - `implementation-notes.html` was kept local and not included in this PR, matching the existing Brightroom notes workflow. ## Validation - Passed: `git diff --check` - Passed: `BrightroomEngineTests/ColorCubeTextParserTests` (4 tests) - Checked: full `BrightroomEngineTests` currently reports 26 passed / 4 failed. The failures are existing `RendererTests` color-space equality assertions for sRGB inputs, not the added LUT tests. - Checked: `SwiftUIDemo` simulator build is currently blocked by missing package product `Reveal-SDK`, not by this LUT change.
…hotoscrop-perspective-projection # Conflicts: # Dev/Brightroom.xcodeproj/project.pbxproj # Sources/BrightroomUI/Shared/Components/Crop/CropView.swift # Sources/BrightroomUI/Shared/Components/Crop/SwiftUICropView.swift # Sources/BrightroomUI/builtin/PhotosCrop/PhotosCropContentView.swift
…hotoscrop-perspective-projection # Conflicts: # Dev/Brightroom.xcodeproj/project.pbxproj
…pective-projection # Conflicts: # .maestro/photos-crop.yaml # Dev/Brightroom.xcodeproj/project.pbxproj # Dev/Brightroom.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # Dev/Tests/BrightroomEngineTests/RendererTests.swift # Sources/BrightroomEngine/Engine/CoreGraphics+.swift # Sources/BrightroomEngine/Engine/RenderCrop.swift # Sources/BrightroomUI/Shared/Components/Crop/CropView.swift # Sources/BrightroomUI/Shared/Components/Crop/SwiftUICropView.swift # Sources/BrightroomUI/Shared/Components/SteppedSlider/BrightroomSteppedSlider.swift # Sources/BrightroomUI/builtin/PhotosCrop/PhotosCropContentView.swift # Sources/BrightroomUI/builtin/PixelEditor/PixelEditorLocalizedStrings.swift # Sources/BrightroomUI/builtin/PixelEditor/SwiftUIPixelEditorView.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.