Repository navigation
chore: remove unused exportStreams util and add stream component stories - #1003
Merged
Austinaminu2 merged 1 commit intoOct 16, 2026
Merged
Conversation
Remove dead code: - Delete utils/exportStreams.ts and its test. The module was only imported by its own test and duplicated lib/export.ts using a separate Stream type with number amounts, while the app uses bigint StreamData. Verified with `grep -r exportStreams` that nothing else references it. Add Storybook stories (components/streams): - stream-templates.stories.tsx: Default list story with interactive selection state wired through the real onSelect/selectedId props. - create-confirmation.stories.tsx: Ready and Pending stories using the component's real bigint props (USDC, 30-day stream). The useTokenPrice hook degrades gracefully to a null price, so no provider mocks are needed. - stream-preview.stories.tsx: WithCliff and WithoutCliff stories covering the cliff step in the chart, cliff stats and timeline. `npx tsc --noEmit` reports no errors and `npm run build` passes. Closes FlowwStar#985 Closes FlowwStar#984 Closes FlowwStar#981 Closes FlowwStar#980
|
@MamaLove360 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#985 Remove unused
utils/exportStreams.tsutils/exportStreams.tsand__tests__/utils/exportStreams.test.ts.lib/export.tswith a separate number-basedStreamtype.grep -r exportStreamsconfirms nothing else references it.#984 StreamTemplates stories
components/streams/stream-templates.stories.tsx: Default list story, with selection state wired through the realonSelect/selectedIdprops.#981 CreateConfirmation stories
components/streams/create-confirmation.stories.tsx: Ready and Pending stories using the component's real bigint props.useTokenPricefalls back to a null price on its own, so no provider mocks are needed.#980 StreamPreview stories
components/streams/stream-preview.stories.tsx: WithCliff and WithoutCliff stories.Verification
npx tsc --noEmit: no errorsnpm run build: passesnpm test: all tests pass except 7 in__tests__/lib/contract-scval.test.ts, which fail onmaintoo and are not related to this PR.Closes #985
Closes #984
Closes #981
Closes #980