Repository navigation
feat: migrate Sentry client config, add global error boundary and stream stories - #1002
Merged
Austinaminu2 merged 1 commit intoOct 16, 2026
Conversation
…eam stories Sentry / Next.js - Move sentry.client.config.ts to instrumentation-client.ts, as Sentry's Next.js guide requires for Turbopack. The existing beforeSend scrubbing (redacted request payloads, truncated Stellar addresses in breadcrumbs) is kept unchanged, and the file exports onRouterTransitionStart for App Router navigation tracing. This removes the "sentry.client.config.ts" deprecation warning from `next build`. - Update the Sentry file reference in DEPLOYMENT.md. - Add app/global-error.tsx, a client error boundary for errors thrown in the root layout. It reports the error through captureError (lib/sentry.ts) and renders a minimal fallback (its own <html>/<body>) with a "Try again" button that calls reset(). This removes the "global error handler" warning from `next build`. Storybook - Add components/streams/download-receipt-button.stories.tsx with ActiveStream and CompletedStream stories, built with the component's real props (stream, creationTxHash, withdrawalTxHashes). - Add components/streams/qr-share-dialog.stories.tsx with an OpenWithSampleStream story (open dialog, sample stream, streaming status). - Both stories include a sonner <Toaster /> decorator so the component toasts render. `npx tsc --noEmit` passes. Closes FlowwStar#987 Closes FlowwStar#986 Closes FlowwStar#983 Closes FlowwStar#982
|
@CodePrincess360 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#987: Move
sentry.client.config.tsintoinstrumentation-client.tsinstrumentation-client.ts, following Sentry's Next.js guide (required for Turbopack).beforeSendscrubbing unchanged: request payloads are redacted and Stellar addresses in breadcrumbs are truncated.onRouterTransitionStartfor App Router navigation tracing.DEPLOYMENT.md.#986: Add
app/global-error.tsxcaptureErrorfromlib/sentry.ts.<html>/<body>and a Try again button that callsreset().#983: Storybook stories for
DownloadReceiptButtoncomponents/streams/download-receipt-button.stories.tsxwith ActiveStream and CompletedStream stories, using the component's real props.#982: Storybook stories for
QrShareDialogcomponents/streams/qr-share-dialog.stories.tsxwith an OpenWithSampleStream story.Verification
npx tsc --noEmitpasses.next buildsucceeds and no longer prints thesentry.client.config.tsdeprecation warning or the "global error handler" warning.npm run storybookcurrently fails for every story in this environment (swc.isWasm is not a function). That is an existing Storybook 9 / Next 16 incompatibility, not something these changes cause, so the new stories could not be checked in a running Storybook.Closes #987
Closes #986
Closes #983
Closes #982