Skip to content

Fix Type Validation For Session ID#6568

Open
yau-wd wants to merge 4 commits into
mainfrom
fix/validate-session-id-types
Open

Fix Type Validation For Session ID#6568
yau-wd wants to merge 4 commits into
mainfrom
fix/validate-session-id-types

Conversation

@yau-wd

@yau-wd yau-wd commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

FLOWISE-415

@yau-wd yau-wd self-assigned this Jun 25, 2026
@yau-wd yau-wd added the bug Something isn't working label Jun 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds type validation checks to ensure that sessionId and chatId are strings, throwing a generic error if they are not. The reviewer suggests improving this by throwing a custom InternalFlowiseError with a BAD_REQUEST status code instead of a generic error, which ensures the client receives a proper 400 Bad Request response rather than a 500 Internal Server Error.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/server/src/utils/index.ts
Comment thread packages/server/src/utils/index.ts
Comment thread packages/server/src/utils/index.ts
yau-wd and others added 3 commits June 25, 2026 20:59
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@yau-wd yau-wd requested a review from igor-magun-wd June 25, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants