Skip to content

#6226 Add test case for handling executable file downloads in decrypt tests#6227

Merged
sosnovsky merged 3 commits into
masterfrom
issue-6226-improve-file-attachment-detection-for-executable-files
May 20, 2026
Merged

#6226 Add test case for handling executable file downloads in decrypt tests#6227
sosnovsky merged 3 commits into
masterfrom
issue-6226-improve-file-attachment-detection-for-executable-files

Conversation

@martgil
Copy link
Copy Markdown
Collaborator

@martgil martgil commented May 20, 2026

This PR adds a new test for executable file downloads, handles the dangerous download confirmation modal, and verifies the downloaded file format and filename.

Closes #6226


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

- Introduced a new thread ID for testing executable file downloads.
- Added logic to handle the confirmation modal for potentially dangerous downloads.
- Verified that the downloaded file matches the expected format and naming convention.

Co-authored-by: Copilot <copilot@github.com>
@martgil martgil requested a review from sosnovsky as a code owner May 20, 2026 08:10
Comment thread test/source/tests/decrypt.ts Dismissed
Comment thread test/source/tests/decrypt.ts Dismissed
Comment thread extension/js/common/core/attachment.ts Outdated
Comment thread extension/js/common/core/attachment.ts Outdated
Comment thread extension/js/common/core/attachment.ts
@martgil martgil marked this pull request as draft May 20, 2026 10:38
@martgil martgil marked this pull request as ready for review May 20, 2026 11:41
@martgil martgil requested a review from sosnovsky May 20, 2026 11:41
Copy link
Copy Markdown
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now, thanks!

@sosnovsky sosnovsky merged commit 18f6120 into master May 20, 2026
12 checks passed
@sosnovsky sosnovsky deleted the issue-6226-improve-file-attachment-detection-for-executable-files branch May 20, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve exectuable file attachment detection

3 participants