Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The manual entry field for Local Sync's connection data used
rememberSaveable, which copies the value into saved instance state and outlives the process. That data holds the session's key, the same as the QR code. It now usesremember, so it stays in memory only and is cleared if Android closes the app in the background. The activity handles rotation itself, so rotating keeps it. This is the same change #1843 made for typed recovery words.Related issue
None.
Change type
Validation
All Gradle commands ran with
--offline -Dorg.gradle.jvmargs="-Xmx4096m -XX:MaxMetaspaceSize=1024m -Dfile.encoding=UTF-8 -Djava.net.preferIPv6Addresses=true".:app:testGithubDebugUnitTest --tests 'io.github.aedev.flow.ui.screens.sync.*' --tests 'io.github.aedev.flow.sync.*': 186 tests, 0 failed.ktlintCheck: exit 0.python3 .github/scripts/nightly_notes.py --check: exit 0.New
SyncManualEntryTestusesStateRestorationTester, like fix(sync): keep typed recovery words out of saved state #1843. It failed withrememberSaveableand passes now../gradlew :app:assembleGithubDebug: not run locally, CI builds it../gradlew :app:testGithubDebugUnitTest: full suite not run locally, CI runs it.I ran any additional flavor-specific build or test tasks affected by this change.
I manually tested the affected behavior on an Android device or emulator: not done.
Test device and Android version: none. The test emulates a saved state restore; no process was killed on a device.
Risk and compatibility
Someone who leaves the screen and comes back after Android closed the app pastes the data again.