Skip to content

fix(player): show the real viewport size in stats for nerds - #1842

Merged
A-EDev merged 2 commits into
mainfrom
fix/stats-viewport
Nov 7, 2026
Merged

A-EDev merged 2 commits into
mainfrom
fix/stats-viewport

Conversation

@A-EDev

@A-EDev A-EDev commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Stats for nerds now shows the real size of the video window. The player reports -1x-1 for a bare Surface, so the reader uses the SurfaceView's own frame and falls back to the player for the TextureView path.
  • A size nobody could measure now reads "-".

Related issue

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug: passed
  • ./gradlew :app:testGithubDebugUnitTest: 5407 tests, 0 failed
  • I ran any additional flavor-specific build or test tasks affected by this change. ./gradlew :app:compileFossDebugKotlin and ./gradlew spotlessCheck: passed
  • I manually tested the affected behavior on an Android device or emulator.

Phone pass: a video read Viewport: 1220x686 on a 1220 wide screen. The TextureView path, which is for Android 13 and below, was not run.

Test device and Android version: Xiaomi 2311DRK48G, Android 16

Screenshots or recordings

Risk and compatibility

Read-only: SurfaceHolder.getSurfaceFrame() runs only while the stats panel is open. No change to how the surface is attached.

  • The change does not introduce secrets, private data, or unexpected telemetry.
  • New user-facing text uses Android string resources.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
  • Breaking changes and upgrade steps are clearly documented.

Copilot AI balanced review requested due to automatic review settings November 7, 2026 17:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions github-actions Bot added documentation Improvements or additions to documentation player Video and audio playback labels Nov 7, 2026
@A-EDev
A-EDev merged commit b0ecdd1 into main Nov 7, 2026
9 checks passed
@A-EDev
A-EDev deleted the fix/stats-viewport branch November 7, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation player Video and audio playback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants