Repository navigation
fix(player): show the real viewport size in stats for nerds - #1842
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Surface, so the reader uses theSurfaceView's own frame and falls back to the player for theTextureViewpath.Related issue
Change type
Validation
./gradlew :app:assembleGithubDebug: passed./gradlew :app:testGithubDebugUnitTest: 5407 tests, 0 failed./gradlew :app:compileFossDebugKotlinand./gradlew spotlessCheck: passedPhone pass: a video read
Viewport: 1220x686on a 1220 wide screen. TheTextureViewpath, which is for Android 13 and below, was not run.Test device and Android version: Xiaomi 2311DRK48G, Android 16
Screenshots or recordings
Risk and compatibility
Read-only:
SurfaceHolder.getSurfaceFrame()runs only while the stats panel is open. No change to how the surface is attached.