Skip to content

fix(appearance): show the theme gradient on placeholders until the thumbnail is read - #1841

Merged
A-EDev merged 2 commits into
mainfrom
fix/skeleton-gradient-before-thumbnail
Nov 7, 2026
Merged

A-EDev merged 2 commits into
mainfrom
fix/skeleton-gradient-before-thumbnail

Conversation

@A-EDev

@A-EDev A-EDev commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • With Gradient loading placeholders on, video page placeholders now show the theme gradient right away, then ease to the thumbnail's colours once it has been read.
  • This also covers a slow connection, or Thumbnail quality set to Off, where the thumbnail doesn't arrive while the page loads.

Related issue

Closes #1815

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug
  • ./gradlew :app:testGithubDebugUnitTest (5,406 tests, 0 failures, 46 skipped)
  • I ran any additional flavor-specific build or test tasks affected by this change. :app:compileFossDebugKotlin passes, ktlintCheck passes.
  • I manually tested the affected behavior on an Android device or emulator.

Emulator with the network throttled to GSM speed and GPRS delay, dark theme: an unseen video shows theme-tinted placeholders until real results replace them, and a video with a cached thumbnail shows its colours straight away.

Test device and Android version: Android emulator, Android 17

Screenshots or recordings

Risk and compatibility

Only applies with the gradient switch on. The colour ease runs once per video while placeholders are on screen.

  • The change does not introduce secrets, private data, or unexpected telemetry.
  • New user-facing text uses Android string resources.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
  • Breaking changes and upgrade steps are clearly documented.

Copilot AI balanced review requested due to automatic review settings November 7, 2026 16:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions github-actions Bot added documentation Improvements or additions to documentation ui Compose UI, theming, or Material 3 surfaces labels Nov 7, 2026
@A-EDev
A-EDev merged commit e6865d3 into main Nov 7, 2026
9 checks passed
@A-EDev
A-EDev deleted the fix/skeleton-gradient-before-thumbnail branch November 7, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ui Compose UI, theming, or Material 3 surfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Enable gradient loading screen

2 participants