Skip to content

feat(pip): add a Next button to the video window - #1838

Merged
A-EDev merged 4 commits into
mainfrom
feat/pip-next-button
Nov 7, 2026
Merged

A-EDev merged 4 commits into
mainfrom
feat/pip-next-button

Conversation

@A-EDev

@A-EDev A-EDev commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • The video picture-in-picture window now has Listen in background, Play or Pause, and Next. With room for only two buttons it keeps the first two.
  • Next calls playerViewModel.playNext(), the same as the on-screen button: the queue first, then the first related video.
  • Next greys out while there is nothing to play, so the other buttons do not move.
  • buildPipParams reads the published state, so every way into PiP shows Next, including the player's own PiP button.
  • While Shorts owns the window, a video kept behind it ignores Next and does not restate the window when its related videos arrive.
  • The Shorts window sets its buttons again once it opens. On the Android 17 emulator the PiP menu greyed Next and lit Previous on the first reel, from correct params, until they were set again.

Related issue

Closes #1824

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug: passed
  • ./gradlew :app:testGithubDebugUnitTest: 5409 tests, 0 failed
  • I ran any additional flavor-specific build or test tasks affected by this change. ./gradlew :app:compileFossDebugKotlin and ./gradlew spotlessCheck: passed
  • I manually tested the affected behavior on an Android device or emulator.

Phone and emulator pass:

  • Entering PiP from Player Settings and by pressing Home both show the three buttons.
  • Next from each window moved to the next video and the window stayed open. Next twice in a row works.
  • Next is grey until related videos arrive, then lights up with no layout change.
  • Listen in background after a Next closes the window and playback continues.
  • The Shorts window shows Previous, Play or Pause, Next. On the first reel Previous is grey, and Next moves to the next reel on both devices.
  • Next in a Shorts window with a video behind it moved the reel and left the video where it was (emulator).

Test device and Android version: Xiaomi 2311DRK48G, Android 16 (HyperOS 3). Resizable_Experimental emulator, API 37

Screenshots or recordings

Risk and compatibility

No player wiring change. Next reuses the existing playNext(). The effect keys on a Boolean, so a change to the related list only touches the window when the answer flips. No new strings or icons.

  • The change does not introduce secrets, private data, or unexpected telemetry.
  • New user-facing text uses Android string resources.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
  • Breaking changes and upgrade steps are clearly documented.

Copilot AI balanced review requested due to automatic review settings November 7, 2026 15:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions github-actions Bot added documentation Improvements or additions to documentation player Video and audio playback ui Compose UI, theming, or Material 3 surfaces labels Nov 7, 2026
@A-EDev
A-EDev merged commit 877be5f into main Nov 7, 2026
9 checks passed
@A-EDev
A-EDev deleted the feat/pip-next-button branch November 7, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation player Video and audio playback ui Compose UI, theming, or Material 3 surfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: next button on pip mode for video

2 participants