Skip to content

fix(sync): drop live messages over the size limit or naming a previous object - #1833

Open
A-EDev wants to merge 2 commits into
mainfrom
fix/sync2-live-limits
Open

A-EDev wants to merge 2 commits into
mainfrom
fix/sync2-live-limits

Conversation

@A-EDev

@A-EDev A-EDev commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

A live message over 64 KiB, or with a non-zero prev, was dropped by nothing on the LAN path: only the server socket limited size. openLive now refuses both, whichever transport carried the message (spec/store.md).

Related issue

None.

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew --offline ... :app:testGithubDebugUnitTest --tests 'io.github.aedev.flow.sync2.*': 303 tests, 0 failed.

  • ./gradlew --offline ... ktlintCheck: passed.

  • python3 .github/scripts/nightly_notes.py --check: passed.

  • New LiveLimitsTest: 2 passed, and both failed before the fix.

  • ./gradlew :app:assembleGithubDebug: not run locally, CI builds it.

  • ./gradlew :app:testGithubDebugUnitTest: full suite not run locally, CI runs it.

  • I manually tested the affected behavior on an Android device or emulator: not done.

Test device and Android version: none.

Risk and compatibility

Live messages only. A sender with a message over 64 KiB is not stopped from sealing it; the receiver drops it.

  • The change does not introduce secrets, private data, or unexpected telemetry.
  • New user-facing text uses Android string resources, or this PR adds none.
  • Dependency and lockfile changes are intentional and limited to this PR. There are none.
  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
  • Breaking changes and upgrade steps are clearly documented. There are none.

Copilot AI balanced review requested due to automatic review settings November 7, 2026 14:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants