Repository navigation
fix(sync): finish the sync when a store refuses an upload - #1828
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A store refusing one of this device's objects ended the sync with an exception. Now the upload stops at that object, keeping the log in order, since skipping it would leave a gap other devices wait at. Pages already sent are saved, the rest of the sync finishes, and the refusal reaches the user through the existing last-sync error. A refused login still ends the sync at once.
Related issue
None.
Change type
Validation
./gradlew --offline ... :app:testGithubDebugUnitTest --tests 'io.github.aedev.flow.sync2.*': 305 tests, 16 failed, all inLinkedProfilesTestwith mockk'sCould not self-attach to current VMfrom this machine's sandbox. CI runs that class../gradlew --offline ... ktlintCheck: passed.python3 .github/scripts/nightly_notes.py --check: passed.New
UploadRefusalTest: 4 passed. With the upload made to skip the refused object instead, 3 of the 4 fail.The call in
LinkedSync.runhas no test of its own: its constructor needs most of the app../gradlew :app:assembleGithubDebug: not run locally, CI builds it../gradlew :app:testGithubDebugUnitTest: full suite not run locally, CI runs it.I manually tested the affected behavior on an Android device or emulator: not done.
Test device and Android version: none.
Risk and compatibility
Background sync only. An object that stays refused keeps this device's later objects from going out, as before, and the error stays visible until the store takes it.