Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A payload's body must now be exactly one gzip member, as flow-sync #102 specifies, so libraries that read gzip framing differently can't take different data from one signed object.
1f 8b 08 00, soFLGis 0.MTIME,XFLandOSaren't checked.bufread::GzDecoderrather thanread::GzDecoder, because the latter's internal buffer swallows what follows the member, sointo_innercouldn't see it.GzDecoderstill checks the CRC-32 andISIZE.Follows flow-sync #102.
Related issue
None.
Change type
Validation
Run on macOS arm64.
pnpm test: not run, no frontend file changedpnpm build: not run, no frontend file changedcargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check: exit 0cargo clippy --all-targets --all-featuresinsrc-tauri: exit 0, no warnings in the files this changescargo test --no-fail-fast --all-targets --all-featuresinsrc-tauri: 1287 passed, 0 failed, 9 ignoredBefore the change,
payloadsfailed on the new negatives. Checked by breaking the code on purpose, one change at a time, withsync2_vectors:read::GzDecoder, whose buffer hides leftoversRisk and compatibility
No format or database change. Every encoder writes
FLG0 and one member; this PR tests only this app's encoder.Not run against Android or a server under this rule.
Overlaps other open PRs on the fixtures README and the changelog.
No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
User-facing documentation was updated where needed. (
spec/crypto.mdin flow-sync [Bug]: Severe UI lag in theatre mode (ResizeObserver layout loop) + main window opens floating/above on Hyprland #102)Dependency and lockfile changes are intentional and limited to this PR. (none)
Breaking changes and upgrade steps are clearly documented. (none for honest clients)