Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Time limits and a connection limit for LAN sessions:
accept, such as running out of descriptors, no longer ends the service. It tries again 100 ms later.Related issue
None.
Change type
Validation
cargo fmt --all: run before committing.cargo test --test sync2_laninsrc-tauri: 22 passed, 1 ignored. The 3 new tests that run by default fail onmain's code.bash -c 'ulimit -n 256; cargo test --test sync2_lan -- --ignored --exact the_service_keeps_accepting_after_running_out_of_descriptors': passed. It's ignored by default because it needs that limit.cargo test --lib lan_: 13 passed, including the new request limit test, which uses paused time.cargo test --test sync2_hybrid --test sync2_live --test sync2_pairing_channel: passed.cargo clippy --all-targets --all-features: no warning left inlan_link.rs,lan_sync.rsorlan_runtime.rs.lan_runtime.rsneeds anAppHandleand has no test, so the rounds are checked by compiling and reading only.Risk and compatibility
No format change, so older and newer devices still meet. The 3-second and 30-second limits are reasoned, not measured on real Wi-Fi. A very long roster on a slow device could take more than 3 seconds to answer a hello; the dialer then tries again on its next round. Anyone on the network can still use the 16 places by reconnecting, which delays members but costs no more than that. Messages before the hello still use the larger LAN frame limit, so 16 connections could briefly hold about 68 MiB. New dev feature:
tokio'stest-util, for paused time; the lock file doesn't change.