Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A store refusing one object stopped the whole sync on a server group:
upload_pendingran with?before push and pull, so nothing more was read either. Writes on a WebDAV group stopped the run the same way.Now:
Related issue
None.
Change type
Validation
cargo fmt --all: run before committing.cargo test --test sync2_hybridinsrc-tauri: passed. The new test fails onmainatpush, and fails if new writes aren't queued behind what was refused.cargo test --test sync2_engine --test sync2_snapshots --test sync2_gc --test sync2_lan: passed.service.rsneeds anAppHandleand has no test, so the order inrunand the WebDAV path were checked by reading only.Risk and compatibility
No format change. An object that stays refused keeps this device's later objects queued, and the error shows on every sync. This change doesn't unstick such a log: other devices wait at the gap, and later writes stay held locally, and on the LAN for peers.