Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
8 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reading stopped at the first page that held a discarded or missing object, so other senders' objects on later pages were never read, against "the device still reads the other senders" in
spec/store.md. Reading now goes on with that sender held back. The saved cursor stays at the first page that held one back, so the next sync lists it again. Objects of a held sender are skipped unless they are the next one it needs, so a log listed backwards across pages still gets read.Related issue
None.
Change type
Validation
cargo fmt --all: run before committing.cargo test --test sync2_engineinsrc-tauri: 12 passed. The 2 new tests fail without the fix.cargo test --test sync2_gc --test sync2_hybrid --test sync2_lan --test sync2_removed_log --test sync2_snapshots --test sync2_webdav: passed.Risk and compatibility
No format change. While a sender stays held back, each sync lists again from that page, up to the existing read limits. Past those limits (200,000 objects), objects after them wait until the held sender moves or its log is collected. Garbage collection keeps logs well below that, so this is reasoned, not measured.