Skip to content

fix(sync): limit live messages on every transport - #449

Open
A-EDev wants to merge 1 commit into
mainfrom
fix/sync2-live-limit
Open

A-EDev wants to merge 1 commit into
mainfrom
fix/sync2-live-limit

Conversation

@A-EDev

@A-EDev A-EDev commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

spec/store.md limits a live message to 64 KiB. The server's socket enforced that, but LAN frames allow far more, so a larger one could still be opened. Opening a live message now checks the limit, whichever transport it came through. The limit lives in one constant.

Related issue

None.

Change type

  • Bug fix

Validation

  • cargo fmt --all: run before committing.
  • cargo test --lib live_seal in src-tauri: passed. With the check taken out, the new test fails.
  • cargo test --test sync2_live --test sync2_server_live: 2 passed; the 2 tests in sync2_server_live are ignored by default and were not run.
  • CI runs the full suite on this PR.
  • Not smoke-tested in a window or on a device.

Risk and compatibility

No format change. Honest messages stay well under the limit: a queue holds at most 50 items.

  • No new secrets, private data, telemetry, or broad Tauri permissions were introduced.

Copilot AI balanced review requested due to automatic review settings November 7, 2026 13:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants