Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec/store.mdlimits a live message to 64 KiB. The server's socket enforced that, but LAN frames allow far more, so a larger one could still be opened. Opening a live message now checks the limit, whichever transport it came through. The limit lives in one constant.Related issue
None.
Change type
Validation
cargo fmt --all: run before committing.cargo test --lib live_sealinsrc-tauri: passed. With the check taken out, the new test fails.cargo test --test sync2_live --test sync2_server_live: 2 passed; the 2 tests insync2_server_liveare ignored by default and were not run.Risk and compatibility
No format change. Honest messages stay well under the limit: a queue holds at most 50 items.