Repository navigation
fix(sync): allow plain HTTP to IPv6 link-local stores as the spec does - #446
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
…http # Conflicts: # src-tauri/src/sync2/http.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec/store.mdallows plain HTTP to a link-local address, but the check left out IPv6 link-local (fe80::/10). So a store at such an address, or a.localname resolving to one, was refused as insecure. The store transport now accepts them. The QR code check is unchanged, since a QR can't carry a zone id.Related issue
None.
Change type
Validation
cargo fmt --all: run before committing.cargo test --test sync2_serverinsrc-tauri: 17 passed. The new assertions failed first (fe80::1refused), andfec0::1stays refused.fe80::may still fail to route on some machines.Risk and compatibility
No format change. Link-local joins the private ranges that are already allowed.