Repository navigation
fix(sync): keep a system proxy away from plain HTTP stores - #445
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
…p-proxy # Conflicts: # changelog/v0.1.0-beta4.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plain HTTP to a private address or a
.localname is allowed only because that address was checked. With a system proxy set, reqwest sent those requests to the proxy instead. Clients for plain-HTTP stores now use.no_proxy(). HTTPS stores still follow the system proxy.Related issue
None.
Change type
Validation
cargo fmt --all: run before committing.cargo test --test sync2_http_proxyinsrc-tauri: 1 passed. With.no_proxy()taken out it fails with "the request went through the proxy".cargo test --test sync2_server --test sync2_webdav: 17 and 19 passed.CI runs the full suite on this PR.
Only the proxy environment variables were run. A proxy set in OS settings was not.
Not smoke-tested in a window or on a device.
Risk and compatibility
A setup that could reach a private store only through a proxy no longer can. That is what the spec's rule asks for.