26.5 bugfixes features test logging#19
Merged
Merged
Conversation
…ad of default value 0 days aka the past.
…f there are signature fails
…ng solution; Make PicketLinkLogger show each class' name
…unused "artifactResolutionHTTPArtifact"
…eme, which was removed in Keycloak 21.0
… saving, and more e2e tests for it
…ponse) and SAMLDataMarshallerTest; minor improvements to other tests
# Conflicts: # .gitignore # pom.xml # src/main/java/nl/first8/keycloak/broker/saml/SAMLEndpoint.java # src/main/java/nl/first8/keycloak/broker/saml/SAMLIdentityProvider.java # src/main/java/nl/first8/keycloak/protocol/saml/SamlProtocolUtils.java # src/main/java/nl/first8/keycloak/saml/processing/core/util/XMLSignatureUtil.java
0314R
force-pushed
the
feature/26.5-bugfixes-features-test-logging
branch
from
1bd36cb to
8ef5c4c
Compare
0314R
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most importantly, we fixed an important bug where signature validation failed in the case of a (valid) ArtifactResponse.
We also added more tests, logging, and fixed some other bugs, mostly in the configuration-frontend (not a theme, but our separate frontend).