Skip to content

dev: Use expect rather than allow#184

Merged
LukeMathWalker merged 2 commits into
mainfrom
allow-not-welcome
Jun 21, 2026
Merged

dev: Use expect rather than allow#184
LukeMathWalker merged 2 commits into
mainfrom
allow-not-welcome

Conversation

@LukeMathWalker

Copy link
Copy Markdown
Contributor

To prevent stale #[allow(...)]s, this PR configures clippy to reject them in favour of the #[expect(..., reason="...")] attribute.

In the process, it performs a few clean-ups:

  • All allows for panic/expect/unwrap in tests are removed. They are unnecessary, given our clippy.toml file:
    allow-unwrap-in-tests = true
    allow-expect-in-tests = true
    allow-panic-in-tests = true
  • (Plausible) reasons are added where they were missing
  • All lints are set to warn. No need to use deny, since we fail on warnings in CI.

…cumbersome. We deny warnings in CI, so 'warn' is sufficient
@LukeMathWalker LukeMathWalker requested a review from veeso June 21, 2026 06:32
@codecov

codecov Bot commented Jun 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@LukeMathWalker LukeMathWalker force-pushed the allow-not-welcome branch 2 times, most recently from a6e2393 to 50474c6 Compare June 21, 2026 06:42
@LukeMathWalker LukeMathWalker merged commit 685fc62 into main Jun 21, 2026
15 checks passed
@LukeMathWalker LukeMathWalker deleted the allow-not-welcome branch June 21, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant