dev: Use expect rather than allow#184
Merged
Merged
Conversation
…cumbersome. We deny warnings in CI, so 'warn' is sufficient
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
a6e2393 to
50474c6
Compare
50474c6 to
4016731
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent stale
#[allow(...)]s, this PR configuresclippyto reject them in favour of the#[expect(..., reason="...")]attribute.In the process, it performs a few clean-ups:
allows for panic/expect/unwrap in tests are removed. They are unnecessary, given our clippy.toml file:warn. No need to usedeny, since we fail on warnings in CI.